From 6df01d3ecba8bcc4fcf557809a5e92801c4afdb6 Mon Sep 17 00:00:00 2001 From: Jan Grodowski Date: Wed, 4 Dec 2024 16:44:48 +0100 Subject: [PATCH] Speed up the test DataWriter to help with a flaky test Affects InterruptResumeTest#test_interrupt_resume_inline_verifier_with_datawriter. My assumption is that ghostferry.run_expecting_interrupt was able to handle TERM before it received anything from DataWriter test_interrupt_resume_inline_verifier_with_datawriter passed 100 consecutive times locally after this change. --- test/helpers/data_writer_helper.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/helpers/data_writer_helper.rb b/test/helpers/data_writer_helper.rb index 8d10363c..d9a7c251 100644 --- a/test/helpers/data_writer_helper.rb +++ b/test/helpers/data_writer_helper.rb @@ -65,10 +65,10 @@ def start(&on_write) until @stop_requested do write_data(connection, &on_write) - n += 1 # Kind of makes the following race condition a bit better... # https://github.com/Shopify/ghostferry/issues/280 - sleep(0.03) + sleep(0.03) if n > 10 + n += 1 end ensure connection.close