Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal not matching documentation #12535

Open
gsouf opened this issue Aug 10, 2024 · 0 comments
Open

Modal not matching documentation #12535

gsouf opened this issue Aug 10, 2024 · 0 comments
Labels
Bug Something is broken and not working as intended in the system. untriaged

Comments

@gsouf
Copy link

gsouf commented Aug 10, 2024

Summary

This is what is advertised in the documentation:

image

This is what we get in the digital world:

image

I have to add a <Box> with padding to match the documentation example

Expected behavior

Get the component to behave as per the documentation or update the documentation.

Actual behavior

Not matching the documentation.

Steps to reproduce

Link to sandbox

  1. Implement a modal as per the documentation:
<ui-modal id="my-modal">
  <p>Message</p>
  <ui-title-bar title="Title">
    <button variant="primary">Label</button>
    <button onclick="document.getElementById('my-modal').hide()">Label</button>
  </ui-title-bar>
</ui-modal>
<button onclick="document.getElementById('my-modal').show()">Open Modal</button>
  1. Open it

Are you using React components?

None

Polaris version number

13.9.0

Browser

any

Device

computer

@gsouf gsouf added Bug Something is broken and not working as intended in the system. untriaged labels Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken and not working as intended in the system. untriaged
Projects
None yet
Development

No branches or pull requests

1 participant