Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon]: All Figma icon components have no description #12538

Closed
jpfinley opened this issue Aug 11, 2024 · 1 comment
Closed

[Icon]: All Figma icon components have no description #12538

jpfinley opened this issue Aug 11, 2024 · 1 comment

Comments

@jpfinley
Copy link

Why are you proposing this update?

Why are you proposing this update?

Problem

There are 95 icons without a description. These descriptions already exist in the codebase but have never made it into the Figma.

Impact

Without that metadata, these icons are harder to find in Figma.

image

Related issues

  • Shopify/admin-ui-foundations#800
  • Shopify/admin-ui-foundations#801

Icon name

Multiple icons

Icon Figma link

No response

Icon SVG code

No response

Are there any other important details?

No response

@jpfinley
Copy link
Author

jpfinley commented Sep 4, 2024

Hi @heyjoethomas, I'm looking for your review on the Add documentation branch of Polaris Icons library.

I've used this plugin to retrieve icon descriptions and keywords from npm and write it to the corresponding icon component set in Figma.

Results:

These icons are present in the npm metadata, but not found in Figma. In most cases they are present but their names do not match.

  • Component set not found for icon: Adjust
  • Component set not found for icon: AtmWithdrawal
  • Component set not found for icon: Catalog
  • Component set not found for icon: GlobeEUFilled
  • Component set not found for icon: GlobeEU
  • Component set not found for icon: sFilledIcon
  • Component set not found for icon: sIcon
  • Component set not found for icon: Inbound
  • Component set not found for icon: MakePayment
  • Component set not found for icon: Outbound
  • Component set not found for icon: Skeleton

There are 98 components missing a description:

  1. ArrowsOutHorizontalFilled
  2. Exchange
  3. ExternalSmall
  4. Import
  5. Payables
  6. Receivables
  7. Share
  8. Sort
  9. Transfer
  10. TransferIn
  11. TransferInternal
  12. TransferOut
  13. Bank
  14. BankFilled
  15. Inventory
  16. CreditCardTapChip
  17. PaginationEnd
  18. PaginationStart
  19. PauseCircle
  20. CodeAdd
  21. SocialPost
  22. OrderFulfilled
  23. OrderRepeat
  24. Target
  25. TargetFilled
  26. Affiliate
  27. Iq
  28. TransactionFeeDollar
  29. TransactionFeeEuro
  30. TransactionFeePound
  31. TransactionFeeRupee
  32. TransactionFeeYen
  33. EmailFollowUp
  34. DnsSettings
  35. PaymentCapture
  36. SkeletonIcon
  37. ThemeEdit
  38. GlobeEurope
  39. GlobeEuropeFilled
  40. Location
  41. MarketsEuro
  42. MarketsEuroFilled
  43. MarketsRupee
  44. MarketsRupeeFilled
  45. MarketsYen
  46. MarketsYenFilled
  47. 3DEnvironment
  48. Arch
  49. AspectRatioPortrait
  50. AspectRatioLandscape
  51. AspectRatioSquare
  52. AspectRatioWidescreen
  53. AspectRatioVertical
  54. Book
  55. Circle
  56. Contrast
  57. Eraser
  58. Exposure
  59. Foreground
  60. Highlight
  61. Icons
  62. IconsFilled
  63. ImageAdd
  64. RoundedCorners
  65. Shadow
  66. Square
  67. ATMWithdrawal
  68. Payment
  69. Purchase
  70. Refund
  71. TipJar
  72. NoteAdd
  73. ReceiptDollar
  74. ReceiptEuro
  75. ReceiptPaid
  76. ReceiptPound
  77. ReceiptRefund
  78. ReceiptRupee
  79. ReceiptYen
  80. SearchList
  81. ShieldNone
  82. ShieldPending
  83. ShieldPerson
  84. CartDiscount
  85. CatalogProduct
  86. Live
  87. LiveFilled
  88. Wifi
  89. Text
  90. CalendarCheck
  91. ClockRevert
  92. Adjustment
  93. AppExtension
  94. Play
  95. SocialAd
  96. Sound
  97. ToggleOn
  98. Variant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants