Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a "=" or a "#" to an erb tag result in a duplicate tag ending #3117

Open
olivierimmosquare opened this issue Jan 31, 2025 · 0 comments
Labels
bug Something isn't working vscode This pull request should be included in the VS Code extension's release notes

Comments

@olivierimmosquare
Copy link

Description

Ruby LSP Information

VS Code Version

1.96.4

Ruby LSP Extension Version

0.9.0

Ruby LSP Server Version

0.23.7

Ruby LSP Add-ons

  • Ruby LSP Rails
  • RuboCop

Ruby Version

3.4.1

Ruby Version Manager

rvm

Installed Extensions

Click to expand
  • RunOnSave (0.2.7)
  • auto-rename-tag (0.1.10)
  • better-comments (3.0.2)
  • copilot (1.261.0)
  • copilot-chat (0.23.2)
  • debugpy (2024.14.0)
  • gitlens (16.2.1)
  • highlight-matching-tag (0.11.0)
  • indent-rainbow (8.3.1)
  • material-palenight-theme (2.0.4)
  • partial-diff (1.4.3)
  • prettyxml (5.2.0)
  • python (2024.22.2)
  • rails-db-schema (0.2.9)
  • rainbow-csv (3.15.1)
  • render-crlf (1.8.5)
  • ruby-lsp (0.9.0)
  • vscode-icons (12.11.0)
  • vscode-pylance (2024.12.1)
  • vscode-rdbg (0.2.2)
  • vscode-react-coffee-pug (0.0.1)
  • vscode-theme-onedark (2.3.0)
  • vscode-theme-onelight (2.3.0)
  • vscode-xml (0.27.2)
  • vscode-yaml (1.15.0)

Ruby LSP Settings

Click to expand
Workspace
{}
User
{
  "enabledFeatures": {
    "codeActions": true,
    "diagnostics": true,
    "documentHighlights": true,
    "documentLink": true,
    "documentSymbols": true,
    "foldingRanges": true,
    "formatting": false,
    "hover": true,
    "inlayHint": true,
    "onTypeFormatting": true,
    "selectionRanges": true,
    "semanticHighlighting": true,
    "completion": true,
    "codeLens": true,
    "definition": true,
    "workspaceSymbol": true,
    "signatureHelp": true,
    "typeHierarchy": true
  },
  "featuresConfiguration": {},
  "addonSettings": {},
  "rubyVersionManager": {
    "identifier": "auto"
  },
  "customRubyCommand": "",
  "formatter": "none",
  "linters": null,
  "bundleGemfile": "",
  "testTimeout": 30,
  "branch": "",
  "pullDiagnosticsOn": "both",
  "useBundlerCompose": false,
  "bypassTypechecker": false,
  "rubyExecutablePath": "",
  "indexing": {},
  "erbSupport": true,
  "featureFlags": {}
}

Reproduction steps

  1. Open an ERB file in Vscode with RubyLSP plugin enabled
  2. Type <% Time.now %>
  3. Try to add = after <% will result in incorrect line <%=%> Time.now %>
    Same for # after <% which result in incorrect line <%#%> Time.now %>

Maybe another bug, but line comment will result in <%# <% Time.now %> %> which is wrong too.

Thanks

@olivierimmosquare olivierimmosquare added bug Something isn't working vscode This pull request should be included in the VS Code extension's release notes labels Jan 31, 2025
jules-w2 added a commit to jules-w2/ruby-lsp that referenced this issue Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vscode This pull request should be included in the VS Code extension's release notes
Projects
None yet
Development

No branches or pull requests

1 participant