Update to App Bridge 4.x ?

[key88sf]

Hi - can this repo be updated to work with the latest App Bridge v4? I have a live app build with this Ruby template using AppBridge v3, and looking at the Shopify migration guide (https://shopify.dev/docs/api/app-bridge/migration-guide), it's unclear where exactly some of the changes need to be made in this template app. It would be great if this repo was updated and folks like me could compare to existing apps. WDYT?

[lizkenyon]

Hey there 👋

We actually just merged these changes, but haven't pulled in these changes to the template just yet.

You can review the changes that were required in this PR.

[key88sf]

@lizkenyon Aha, great. Thank you! 👍

[douglasmiller]

@lizkenyon, I might be missing something obvious, but the env var replacement does not occur when I pull in the changes from the linked pull request.

Will there be more changes necessary in the rails template to accommodate the react template's updates?

Edit: It appears that the proxy configuration causes import.meta.env to be undefined. This is because the vite server's proxy routes all requests to / (with or without query string) to the rails application. The rails application just serves the raw index.html file instead of a version that has been preprocessed by vite.

[key88sf]

@lizkenyon Have the changes been pulled into this project yet?

[lizkenyon]

Hey @key88sf 👋

Yes they have. If you create a new app with shopify app init --template=ruby you will see the features of App Bridge 4.x.x

[key88sf]

@lizkenyon Ok thanks. For future huge changes like this, it would be great to have a migration guide specifically for folks using apps based on this template as well. I'm doing the changes now and there is a lot of stuff to work out...

[lizkenyon]

You can view the App Bridge migration guide here. Though you are correct we don't have a Ruby template specific migration guide, and something for us to consider in the future.

[key88sf]

Yeah been using the app bridge general one.