Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group suggested in wrong place when building a select schema setting #730

Open
david-w-shopify opened this issue Jan 23, 2025 · 0 comments
Labels
Bug Something isn't working SEV-3 Normal Severity

Comments

@david-w-shopify
Copy link

Describe the bug
When building a select setting in a section/block schema, the group key is surfaced in intellisense at the root setting level, instead of the option level, where it is valid.

Just to make sure, I tried adding group to the root of the setting and got an error from the CLI.

Source

{% schema %}
{
  "name": "Section",
  "settings": [
    {
      "type": "select"
      "id": "select",
      "label": "Select",
      "" // group is suggested here
      "options": [
        {
          "label": "Option",
          "value": "option",
          "" // group is not suggested here
        }
      ]
    }
  ]
}
{% endschema %}

Expected behaviour
group key is not suggested when I try to add a property at the same level as "label": "Select", and is suggested when I try to add a property at the same level as "value": "option".

Actual behaviour
Image

Image

Debugging information

  • OS: Mac
  • OS Version: Sequoia 15.2
  • Extension Version: 3.5.1
@aswamy aswamy added Bug Something isn't working SEV-3 Normal Severity labels Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working SEV-3 Normal Severity
Projects
None yet
Development

No branches or pull requests

2 participants