Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore options to version API docs and tie them to our repos #744

Open
ChrisSchinnerl opened this issue Sep 19, 2024 · 3 comments
Open
Labels
documentation Improvements or additions to documentation

Comments

@ChrisSchinnerl
Copy link
Member

Adding this to this repo since it's really relevant to all of our node repos.

With v2.0 around the corner we should improve our process for API documentation a bit. Ideally we'd tie our documentation to commits in our repos. Meaning that the same PR that changes a route also adds the documentation for it. Which should improve the quality of our docs overall.
Also it would be cool if users had the option to pick a specific version of our API in the docs.

It seems like prometheus has support to link an API to a repo by checking in an openapi spec and the collection. So we should perform some research to see if that is a viable option for our APIs.

@ChrisSchinnerl ChrisSchinnerl converted this from a draft issue Sep 19, 2024
@ChrisSchinnerl ChrisSchinnerl added the documentation Improvements or additions to documentation label Sep 19, 2024
@alexfreska
Copy link
Member

@ChrisSchinnerl ideas:

@ChrisSchinnerl
Copy link
Member Author

I think Postman also lets us generate API documentation from an openapi spec. The tricky part I think is finding a nice way for devs to keep it updated. But the swaggo annotations look pretty promising if we can just keep them right next to our go routes.

@n8maninger any thoughts on Go swag? I think you said you used swagger before.

@n8maninger
Copy link
Member

n8maninger commented Sep 19, 2024

I’m heavily against annotations in code. Other than that no real preference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Todo
Development

No branches or pull requests

3 participants