Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE]: When attempting to save a view, the application currently allows saving even if the label field is left empty or contains only whitespace. #6445

Open
Aarif5435 opened this issue Nov 15, 2024 · 2 comments

Comments

@Aarif5435
Copy link

Bug description

When attempting to save a view, the application currently allows saving even if the label field is left empty or contains only whitespace. This leads to confusion and inconsistent view names in the UI.

Expected behavior

The application should prevent saving a view with an empty label or a label containing only whitespace. An error message should prompt the user to enter a valid label name before proceeding.

How to reproduce

  1. Open the "Save this view" dialog.
  2. Leave the "Label" field empty or enter only spaces.
  3. Click on the "Save this view" button.
  4. Observe that the view is saved despite the empty or whitespace-only label.

Screenshort

view-save.mp4

Version information

  • Signoz version: 0.56
  • Browser version: Version 130.0.6723.119
  • Your OS and version: macOS
  • Your CPU Architecture: ARM

Additional context

This issue impacts the user experience as it allows views to be saved without meaningful names, making it difficult to identify saved views later. A validation check should be added to ensure that the label field contains non-whitespace characters before allowing the view to be saved.

Thank you for your bug report – we love squashing them!

Copy link

welcome bot commented Nov 15, 2024

Thanks for opening this issue. A team member should give feedback soon. In the meantime, feel free to check out the contributing guidelines.

@Aarif5435
Copy link
Author

I have fixed this issue, please have look to the PR.
PR:- #6446

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant