diff --git a/src/NH/Bass/Command.h b/src/NH/Bass/Command.h index b9cc105..ceeadd2 100644 --- a/src/NH/Bass/Command.h +++ b/src/NH/Bass/Command.h @@ -22,8 +22,8 @@ namespace NH::Bass struct Command { - virtual CommandResult Execute(Engine& engine) = 0; + virtual ~Command() = default; }; class FunctionCommand : public Command diff --git a/src/NH/Bass/EventManager.h b/src/NH/Bass/EventManager.h index c87758b..fbf4dff 100644 --- a/src/NH/Bass/EventManager.h +++ b/src/NH/Bass/EventManager.h @@ -32,6 +32,7 @@ namespace NH::Bass Event() = delete; Event(EventType type, DataType data) : Type(type), Data(data) {} + virtual ~Event() = default; }; using EventSubscriberFn = void (*)(const Event&, void*); diff --git a/src/NH/Bass/IChannel.h b/src/NH/Bass/IChannel.h index 049ec91..5698a20 100644 --- a/src/NH/Bass/IChannel.h +++ b/src/NH/Bass/IChannel.h @@ -32,6 +32,8 @@ namespace NH::Bass template using Result = std::expected; + virtual ~IChannel() = default; + virtual Result PlayInstant(const AudioFile& audioFile) = 0; virtual void StopInstant() = 0; diff --git a/src/NH/Bass/IEngine.h b/src/NH/Bass/IEngine.h index c894678..e9d8f5a 100644 --- a/src/NH/Bass/IEngine.h +++ b/src/NH/Bass/IEngine.h @@ -10,6 +10,8 @@ namespace NH::Bass struct IEngine { + virtual ~IEngine() = default; + /** * Get a free channel and mark it as busy * @return shared_ptr to a free channel (or null if all channels are busy) diff --git a/src/NH/Executor.h b/src/NH/Executor.h index c66fa6a..7adb645 100644 --- a/src/NH/Executor.h +++ b/src/NH/Executor.h @@ -17,6 +17,7 @@ namespace NH { virtual void AddTask(TaskFN&& task) = 0; virtual void AddTask(const TaskFN& task) = 0; + virtual ~Executor() = default; }; class InstantExecutor : public Executor diff --git a/src/NH/Logger.h b/src/NH/Logger.h index cf843f6..3c4cb61 100644 --- a/src/NH/Logger.h +++ b/src/NH/Logger.h @@ -42,6 +42,7 @@ namespace NH LoggerLevel m_Level; explicit ILoggerAdapter(LoggerLevel level = LoggerLevel::Debug) : m_Level(level) {} + virtual ~ILoggerAdapter() = default; bool CanLog(LoggerLevel level) const { return level <= m_Level; }