Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STORY] Split the code to components independent of Union API #38

Open
4 tasks
piotrmacha opened this issue Jun 18, 2024 · 0 comments
Open
4 tasks

[STORY] Split the code to components independent of Union API #38

piotrmacha opened this issue Jun 18, 2024 · 0 comments
Labels
story Task or feature that needs to be done

Comments

@piotrmacha
Copy link
Member

piotrmacha commented Jun 18, 2024

Story
As a Developer, I want to extract the core code to a separate static library independent of Union API, so that it can be linked to automatic tests.

Union API makes the core code really difficult to test because it has a debug main() method and some features wouldn't work outside the Gothic runtime. Core code should be refactored to become completely independent of Union API and every interaction with it in the direction Core-->Union should be inverted to Core<|--Union by providing public interfaces for Union to implement and inject.

Definition of Done

  • [Core code (NH and NH::Bass namespaces) is not referencing Union API nor Gothic API]
  • [Core code is extracted as an independent STATIC library]
  • [Union specific code is moved to NH::Union namespace and built as SHARED library with the plugin]
  • [Union SHARED library links STATIC Core]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story Task or feature that needs to be done
Projects
None yet
Development

No branches or pull requests

1 participant