From fde16d2e628daca40fad5ef04b74b7d84f0c9b6a Mon Sep 17 00:00:00 2001 From: Simon Cropp Date: Thu, 27 Feb 2025 13:55:00 +1100 Subject: [PATCH] Make public static fields get only properties (#497) --- src/Directory.Build.props | 2 +- src/NaughtyStrings.Bogus/Naughty.cs | Bin 45952 -> 46048 bytes src/NaughtyStrings.sln | 1 + src/NaughtyStrings/TheNaughtyStrings.cs | Bin 126074 -> 126710 bytes src/Tests/GlobalUsings.cs | 2 ++ src/Tests/Sync.cs | 12 +++++++----- 6 files changed, 11 insertions(+), 6 deletions(-) diff --git a/src/Directory.Build.props b/src/Directory.Build.props index cc0c244..1734511 100644 --- a/src/Directory.Build.props +++ b/src/Directory.Build.props @@ -2,7 +2,7 @@ CS1591 - 2.4.1 + 3.0.0 1.0.0 preview NaughtyStrings, Bogus diff --git a/src/NaughtyStrings.Bogus/Naughty.cs b/src/NaughtyStrings.Bogus/Naughty.cs index 15bcc1c26667931a9e3f6fb29a6781dca933babb..59abd1076c1df9eb7b26435aae3b8ccdd67eca81 100644 GIT binary patch delta 138 zcmZp8&h+3pQ~m#c`V9IE3Jf+3i43I-B@Fotx(w+IsSJ5QTm%#=0n#Zzd3^>u23`g( z24#iKp1p&UpS0aa%LaXOHn0%R2f#gZ6ufI2}sN`ZWstP{}ubg+muSdMq2 HeBx#RU+^2} delta 13 VcmaFxoT=eC6Vv~H8%%U_4i$Udj3wjU}7uwQn&N*|G>3ppq;ZlF` zsR;!|_;tx!Jxwvgu=1mHWrp^F(iakBHv77FD=l~Hp@$y++daSYJLmlF`JeOm`yyw? zB5S{WH6Q~@LRrXyDv=YFp;Tl=Maae;2g97~zmWM2Xgi8VN|cQ30o;m?GH(*9V!sZ? zE@qFF*@f&>!LWm9{dtZItRDy>t60Qa9c*5(GW0OCU};ie7q`;Vix~5=5n=<@RDv{|25LMlQ_{wC zP=~i?`nO3J@?azNy1*7D_2zM~=9SsU7zp;trTyKbG0TZ_}g8q22;r3G{LzWJXazwLM zO^-~%Ip8Wu(?eO9puMT`#US?h%w$G>{P%XdpYM+pG813th6^3uX`?vzmJbm^2d?jw zlT)9rhR6&ks`=6=6V%zm?)zf~>gM**4gi~CF^y`JutHdp)~KL8Wa@Z5>WYCkAxfxa zIouasm%7w&Pn3xX{QF4aEPW=fpEJ?-NsuGTV8(8}jWO(!KMrE3BN+~hX|wu4PNRh> zkS}8JUj4)1A6TeuGCPUn4CQwEh7ha3xb$te&p|qnHltKz_?N^YJZWsUh1XotFbVC(&--Rop z!8TJzKMaO==#C+%3_*DVCHpWaiM=-$*!wD=T_d0n3(4-26W^UU8Kaq~V-#wHG~(}5 oh4W0fZ$u$AKZ6&7zVL|(er;&mODGp6q9v0sEmTaKUV#t31CmYwCjbBd delta 1034 zcmc&zUr19?9Om2Z{y5jlVRPMNRt!WPF{Zr?DzOm;5)s1(iI9j0q9GDCL`r0Y4-&(J zUPuawkRBwahy0~Ph}iN$D#pcZH5=AL|Ir>qhFEv!<{&WWt+(@i=l7j+?)QCnEn~?o zS`0ro$1bdag)@!3_4TNM)fd@$#1u8*09&;U^%q-NUvVAtN^YJm_B*-VV}=rT!_9pa zBUY|f4nu6-ta5>mR2#tVmAUy$%^>JO6<&h1m+YaT8q|UXjBfhu%X8X__XI*>!LqeY z)EP%F}Nfp{t$MyGHzvUB$0gryTFx z7LSmB8jIUJ)H{bIffWCHSn0?-qR=jrctf%d%vJ8@@n=gm-j+)1{+w6uO218BHu7+0 zW*dWTADS&1qYra&0chFiT&gxess_^`ux)CbKJ+$t}K3#q# zkWWqP3u%4n5}Z~T*+kmc_X((E$KhZrM;&}Rs2(mfo z91}0#G?F(3Sr=vJ()p0XN^$`kq`pF_&QH%vbo>p{0#WBXw3tP9?Wsl0k&OsNKSKLG Q^YN;mup)vb&o?aM7c$?RsQ>@~ diff --git a/src/Tests/GlobalUsings.cs b/src/Tests/GlobalUsings.cs index 344355b..6d98ac3 100644 --- a/src/Tests/GlobalUsings.cs +++ b/src/Tests/GlobalUsings.cs @@ -1,2 +1,4 @@ +global using System.CodeDom; +global using System.CodeDom.Compiler; global using Bogus; global using NaughtyStrings; \ No newline at end of file diff --git a/src/Tests/Sync.cs b/src/Tests/Sync.cs index 60c0641..c24bf3a 100644 --- a/src/Tests/Sync.cs +++ b/src/Tests/Sync.cs @@ -1,7 +1,4 @@ -using System.CodeDom; -using System.CodeDom.Compiler; - -public class Sync +public class Sync { [Fact] public async Task SyncNaughtyStrings() @@ -39,6 +36,8 @@ static void WriteBogus(StreamWriter writer, List categories) { writer.WriteLine( """ + // + #pragma warning disable using Bogus; namespace NaughtyStrings.Bogus; @@ -103,6 +102,9 @@ static void WriteNaughtyStrings(StreamWriter writer, CodeDomProvider provider, L { writer.WriteLine( """ + // + #pragma warning disable + #if Bogus namespace NaughtyStrings.Bogus; #else @@ -137,7 +139,7 @@ static void WriteList(StreamWriter writer, CodeDomProvider provider, string name /// /// {{comment}} /// - public static IReadOnlyList {{name}} = new List + public static IReadOnlyList {{name}} { get; } = new List { """); foreach (var line in lines)