Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default savedir in movegroup saves files to dirname(tempdir()), not tempdir() #20

Open
mhpob opened this issue Oct 29, 2023 · 3 comments
Open

Default savedir in movegroup saves files to dirname(tempdir()), not tempdir() #20

mhpob opened this issue Oct 29, 2023 · 3 comments

Comments

@mhpob
Copy link

mhpob commented Oct 29, 2023 •
edited
Loading

Many objects are saved to files created by paste0, for example: https://github.com/SimonDedman/movegroup/blob/main/R/movegroup.R#L372-L373

Resulting in files being saved as /home/me/folderNEWFILE rather than /home/me/folder/NEWFILE.

Could be solved by using file.path instead of paste0, as in https://github.com/SimonDedman/movegroup/blob/main/R/movegroup.R#L591

Happy to PR for you if that would help.
@mhpob mhpob mentioned this issue Oct 29, 2023
Closed
@SimonDedman
Copy link
Owner

edits pushed for movegroup.R; not for scaleraster.R alignraster.R & plotraster.R yet but will do asap. Debug in windows.

@SimonDedman
Copy link
Owner

Hopefully fixed by commit, reopening until tested on windows & linux

@SimonDedman SimonDedman reopened this Dec 5, 2023
@SimonDedman
Copy link
Owner

Extra tweaks here, ended up basically duplicating Mike's effort in #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimonDedman @mhpob