Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Stop download tasks without custom location when app is killed or crashes #35

Open
SimonSimCity opened this issue Nov 22, 2016 · 1 comment
Labels

Comments

@SimonSimCity
Copy link
Owner

There is some code in the Android version, that should be used for re-initializing download-tasks that haven't finished while the app was running.

As we can't surely say which tasks belong to our app when restarting the app (the browser may also has some items in there) and the filter for running, paused and queued tasks doesn't work on Android 4.x (see #33), I think the best option we currently have is to stop all downloads that are done against the temporary location.

The downloads that are going to a custom location cannot be queried but you can see that they finished by the time the file is already downloaded.

I'm also working on a check for re-initializing an ongoing download if you try to download the file again. The system then throws an error that this file already is queued and we'll just catch it up, because it was in the native queue, but not in the queue of this lib.

This is just required as long as we use Androids implementation of the DownloadManager. #34 would make this request invalid.

@SimonSimCity SimonSimCity added this to the 1.0 milestone Nov 22, 2016
@SimonSimCity SimonSimCity changed the title [Android] Stop downloading task without custom location [Android] Stop downloading task when app is killed or crashes without custom location Nov 22, 2016
@SimonSimCity SimonSimCity changed the title [Android] Stop downloading task when app is killed or crashes without custom location [Android] Stop download tasks without custom location when app is killed or crashes Nov 26, 2016
@SimonSimCity SimonSimCity removed this from the 1.0 milestone Feb 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant