Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSKeychain has been renamed to SAMKeychain #556

Open
danielr opened this issue Aug 29, 2016 · 3 comments
Open

SSKeychain has been renamed to SAMKeychain #556

danielr opened this issue Aug 29, 2016 · 3 comments

Comments

@danielr
Copy link

danielr commented Aug 29, 2016

Due to a name clash with private frameworks in iOS 10, SSKeychain has been renamed to SAMKeychain, see soffes/SAMKeychain#140. You should probably update your dependencies (e.g. podspec) accordingly and use the new class name internally.

@jleandroperez
Copy link
Contributor

Thank you for the heads up @danielr!! I wasn't aware of this collision (though i'm running iOS 10).

We'll be wiring the new SAMKeychain ASAP.

Hope you're doing well sir!!

@jleandroperez
Copy link
Contributor

(By the way) forgot to mention, current apps are safe, since we're using a "namespaced" version of SSKeychain, so nothing should break. (It's actually SPKeychain in our project).

@danielr
Copy link
Author

danielr commented Aug 30, 2016

Thanks Jorge! I wasn't looking closely and didn't notice that you forked the library for namespacing purposes (but now I remember that we had that discussion some time ago). I guess then everything is fine as it is. :-) NB: This is not actually causing any problems currently, I just came across that rename and thought I'd let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants