Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Andromeda broke with beta 35+ #794

Closed
melontini opened this issue Jan 31, 2024 · 6 comments · Fixed by #877
Closed

Andromeda broke with beta 35+ #794

melontini opened this issue Jan 31, 2024 · 6 comments · Fixed by #877
Assignees
Labels
compat A mod is found to be incompatible fixed in dev Fixed in dev. Awaiting a new release.

Comments

@melontini
Copy link
Contributor

Mod Name

Andromeda

Mod Homepage

https://github.com/melontini/andromeda

Minecraft version

1.20.1

Describe the bug

Crash due to Adapter patches not applying (?)

Steps to reproduce

  1. Launch the game with items.infinite_totem or world.quick_fire enabled in Andromeda's config
  2. Mixin can't locate injection targets.

Logs

items.infinite_totem: https://mclo.gs/RG6Xon1

Additional context

Confirmed with this build https://github.com/Sinytra/Connector/actions/runs/7716373181

@melontini melontini added the compat A mod is found to be incompatible label Jan 31, 2024
@Su5eD Su5eD self-assigned this Jan 31, 2024
@Su5eD Su5eD moved this from 🆕 New to 👀 In review in Connector Triage Jan 31, 2024
@Su5eD Su5eD added the fixed in dev Fixed in dev. Awaiting a new release. label Jan 31, 2024
@Su5eD Su5eD linked a pull request Jan 31, 2024 that will close this issue
@Su5eD Su5eD closed this as completed in #783 Feb 4, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Connector Triage Feb 4, 2024
@melontini
Copy link
Contributor Author

Doesn't look like beta 36 fixed the issue.

@Su5eD Su5eD reopened this Feb 4, 2024
@Su5eD Su5eD removed the fixed in dev Fixed in dev. Awaiting a new release. label Feb 4, 2024
@Su5eD Su5eD moved this from ✅ Done to 🆕 New in Connector Triage Feb 4, 2024
@Su5eD Su5eD moved this from 🆕 New to 🔖 Confirmed in Connector Triage Feb 5, 2024
@melontini
Copy link
Contributor Author

Seems like 1.8.0 is broken on all Connector versions.

@melontini
Copy link
Contributor Author

It's not "seems". Some time ago, connector stopped piping every class to the mixin transformer, and since Andromeda generates its mixin configs at runtime, no patches are applied. 😛

@mateus3c
Copy link

so thats why my modpack was crashing after updating connector... glad this is being checked

@melontini
Copy link
Contributor Author

so thats why my modpack was crashing after updating connector... glad this is being checked

This should only affect modpacks with Andromeda (all 3 of them), but even then, Andromeda will disable the module if some mixin fails to apply. This also only affects world/quick_fire and items/infinite_totem.

If you're trying to run AM without those modules, then the issue is in something else.

@Su5eD
Copy link
Member

Su5eD commented Mar 12, 2024

You're right, I just piped everything through the mixin patch transformer and Andromeda worked again, lol. Sorry about this stupid issue, fixing it right now.

@Su5eD Su5eD moved this from 🔖 Confirmed to 🏗 In progress in Connector Triage Mar 12, 2024
@Su5eD Su5eD removed a link to a pull request Mar 12, 2024
@Su5eD Su5eD moved this from 🏗 In progress to 👀 In review in Connector Triage Mar 12, 2024
@Su5eD Su5eD added the fixed in dev Fixed in dev. Awaiting a new release. label Mar 12, 2024
@Su5eD Su5eD linked a pull request Mar 12, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Connector Triage Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat A mod is found to be incompatible fixed in dev Fixed in dev. Awaiting a new release.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants