Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing breakpoint from VSCode doesn't work #17

Open
thomthom opened this issue Feb 16, 2018 · 9 comments
Open

Removing breakpoint from VSCode doesn't work #17

thomthom opened this issue Feb 16, 2018 · 9 comments
Labels

Comments

@thomthom
Copy link
Member

thomthom commented Feb 16, 2018

When I set a breakpoint in VSCode, then try to remove it during a debug session it continues to break.

In this current scenario where I observe that I set a breakpoint within a loop. After hitting the breakpoint I then remove it and continue execution. But the code continues to break at the line where the breakpoint used to be. VSCode no longer lists any breakpoints.

Seems to be a synchronization issue.

vs-code-debug-issue-17.zip

vscodedebugissue

  1. Set a breakpoint inside a loop
  2. Run the code that trigger the breakpoint
  3. Remove the breakpoint from VSCode
  4. Continue execution (F5)

Expected behaviour is that the loop continues without hitting the removed breakpoint.
Observed behaviour is that the breakpoint continues to break.

Compare this to RubyMine which works as expected:

rubyminedebug

@thomthom thomthom added the bug label Feb 16, 2018
@BugraBarin
Copy link
Member

I can't duplicate. Can you provide a minimal VSCode folder that shows this?

@thomthom
Copy link
Member Author

@BugraBarin I added a Zip file with complete extension project and fleshed out repro steps.

@BugraBarin
Copy link
Member

Thanks that did it. Breakpoint doesn't have to be in a loop either. I am also seeing an assertion within VSCode when trying to remove the breakpoint and the message never gets sent to our debugger. This definitely looks to be all occurring within the VSCode extension.

@thomthom
Copy link
Member Author

thomthom commented Feb 26, 2018

So then we should probably prepare an example for standalone Ruby and submit that to the VSCode extension?

(Any idea how one run a Ruby debug server for standalone Ruby?)

@BugraBarin
Copy link
Member

That would be worth pursuing. Something about that folder may be causing it, maybe the path names.

@thomthom
Copy link
Member Author

Why would the path names be of significance? I'm able to set/remove breakpoint as long as the debugger isn't busy stepping through code.

@thomthom
Copy link
Member Author

I managed to reproduce it with standalone Ruby. Even found an existing issue:

rubyide/vscode-ruby#44

Though it's nearly two years old... :/

@BugraBarin
Copy link
Member

Good find! We may have to dig into it ourselves.

@thomthom
Copy link
Member Author

Any experience with VSCode extension development?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants