refactored areas for Apply & Admin #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor-inner-API-and-Web-to-use-BaseMediator-approach-for-new-qualifications Peter/award 261 refactor inner api and web to use base mediator approach for new qualifications
…fication-controller-with-best-REST-API-practices REST API best practices refactor
…ions-QuestionOptions Award 220 pages questions question options
#44) * Added distributed memory cache to web if in development in aodp.web - currently after dataprotect in dev flow. Ran and tested locally for login and direct page navigation. Removed caching references in aodp.authentication as ticket store will use what is defined in program.cs to my knowledge via DI. The code is as was in terms of the openid config from sprint 3. * Stub auth code in program moved into the auth project Exracted roles class out of program Added Extension method for distributed cache Removed distrubted cache from DP as added on previous commit. Removed redundant usings Removed commented out code that was already in program.cs Tested local auth against external provider. Tested direct page auth. Tested Signout of external provider Tested stub code works Utilised rediconfiguration connectionstring already used for dp Can only test the redis cache once deployed. * configuration.getsection for the connection is no longer required as moved out to adddistrbutedcache extension * missing using. Git was being confusing.
…d integrate with backend service (#48)
…stion-Guidance-Description-field-should-accept-markdown-and-provide-a-preview-of-the-rendered-HTML
Award 220 sections
…t figma image. (#54)
#39) Co-authored-by: David Rimar <[email protected]>
DASD-12820 - Updated YAML to reference DEMO VG
…rkdown-Warning Added warning against using Markdown headers to the form builder Markdown helper.
…-App-Create-CSV-download-functionality-for-new-qualifications
#60) * Policies defined for isreviewuser, isapplyuser,isadminformsuser and isadminimport user Polices are defined via conventional routes within program.cs Root home now contains links to static home pages for each START page AutoRedirect via link on home page that redirects user to appropriate area depending on who they authenticate as either /admin /admin/import /review /apply. User will only be able to access areas that they have the appropriate policy for. This applies after authentication as well if manually redirect to url. 403 page created. Currently 403 page contains autoredirect link if authenticated to take you to the area you have access to via policy def, * Added role constants and updated program.cs to use these. * apply (A0) home page markup updated to figma design * Forgot to commit update to roleconstants file. * Simplied not authorised page . Thought originally would be in wwwroot, revised to use standard layout . Removed capitalisation on the initial index page of start and landing. * not authorised file commit * Qualification routing change back to how it was. Clarified with peter the reason for the change from a route parameter to fromquery. Modified The routes accordingly and the endpoint is now accessible and locked down via the policy. The qualification work resides under /review/qualifications and is locked down with the review policy Qualification page has two exposed methods each returning a different view. There's no data and it resulted in a 404 so i added a call to app.UseStatusCodePagesWithRedirects("/Error/{0}"); Whenever a 403 or 404 occurs a redirect will occur to the appropriate not authorised or not found action. I Imagine these error pages will need further styling work going forward
Made text validation use word count instead of character length.
…ate-CSV-download-functionality-for-new-qualifications Award 363 web app create csv download functionality for new qualifications
This reverts commit 4a2753f.
This reverts commit 185b99e.
HamzaIbraheem-DFE
changed the title
|
DavidRimarDfE
approved these changes
Feb 27, 2025
DavidRimarDfE
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.