Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmentation tab does not work correctly when more than 16 series are selected. #111

Open
brikeats opened this issue Feb 24, 2016 · 9 comments
Assignees

Comments

@brikeats
Copy link
Contributor

Selecting more than 16 series causes a divide by zero error on line 1407. This is because the if statement on lines 1399-1406 does't catch the case when nVolumeNodes > 16.

@fedorov
Copy link
Member

fedorov commented Feb 24, 2016

Good catch! I didn't test with such configuration. Can you propose a patch that will make it work with more than 16 series? It will be a very crowded view, so please choose something that you like - I don't think we ever considered looking at that many series at once, just because of the screen size limitation.

@brikeats
Copy link
Contributor Author

Maybe it make more sense to restrict the number of selectable series? Or just have it default to 4x4 for more than 16 series? As you said, with more than 4x4, it gets too crowded to be useful.

@fedorov
Copy link
Member

fedorov commented Feb 24, 2016

Both showing less viewers than series and restricting the maximum number of selected series will be a bit tricky to handle (not intuitive, additional notifications, logic). I think it is better to create enough viewers to fit all series, and if the views are too small, user can go back and unselect.

@fedorov
Copy link
Member

fedorov commented Feb 24, 2016

I meant to say, to fit all selected series.

brikeats added a commit to rcc-uchicago/PCampReview that referenced this issue Feb 24, 2016
che85 pushed a commit to che85/mpReview that referenced this issue Mar 2, 2016
@fedorov
Copy link
Member

fedorov commented Jun 8, 2016

@brikeats are you still working on this project?

@brikeats
Copy link
Contributor Author

brikeats commented Jun 9, 2016

@fedorov sorry, no. I'm no longer at UChicago (joined a startup called Uptake), and I doubt I'll have the time.

@fedorov
Copy link
Member

fedorov commented Jun 9, 2016

@brikeats thanks for the update! Is there another person in Aytek related group involved with it, or you don't know? Just trying to get an idea how much coordination we need to do with the Aytek's group, and who is the contact (if any).

@brikeats
Copy link
Contributor Author

brikeats commented Jun 9, 2016

@fedorov They didn't have a replacement for me when I left (~6 weeks ago), and I haven't heard anything about it since. you're probably best off asking Aytek or Dr. Runesha directly about their plans for this project.

@fedorov
Copy link
Member

fedorov commented Jun 9, 2016

@brikeats alright, thanks! Good luck at the new job!

p.s. You should read this book, if you haven't yet: https://www.amazon.com/Lean-Startup-Entrepreneurs-Continuous-Innovation/dp/0307887898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants