-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segmentation tab does not work correctly when more than 16 series are selected. #111
Comments
Good catch! I didn't test with such configuration. Can you propose a patch that will make it work with more than 16 series? It will be a very crowded view, so please choose something that you like - I don't think we ever considered looking at that many series at once, just because of the screen size limitation. |
Maybe it make more sense to restrict the number of selectable series? Or just have it default to 4x4 for more than 16 series? As you said, with more than 4x4, it gets too crowded to be useful. |
Both showing less viewers than series and restricting the maximum number of selected series will be a bit tricky to handle (not intuitive, additional notifications, logic). I think it is better to create enough viewers to fit all series, and if the views are too small, user can go back and unselect. |
I meant to say, to fit all selected series. |
…select All Series" buttons are clicked. Fixes issue SlicerProstate#111.
…select All Series" buttons are clicked. Fixes issue SlicerProstate#111.
@brikeats are you still working on this project? |
@fedorov sorry, no. I'm no longer at UChicago (joined a startup called Uptake), and I doubt I'll have the time. |
@brikeats thanks for the update! Is there another person in Aytek related group involved with it, or you don't know? Just trying to get an idea how much coordination we need to do with the Aytek's group, and who is the contact (if any). |
@fedorov They didn't have a replacement for me when I left (~6 weeks ago), and I haven't heard anything about it since. you're probably best off asking Aytek or Dr. Runesha directly about their plans for this project. |
@brikeats alright, thanks! Good luck at the new job! p.s. You should read this book, if you haven't yet: https://www.amazon.com/Lean-Startup-Entrepreneurs-Continuous-Innovation/dp/0307887898 |
Selecting more than 16 series causes a divide by zero error on line 1407. This is because the
if
statement on lines 1399-1406 does't catch the case whennVolumeNodes > 16
.The text was updated successfully, but these errors were encountered: