Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections to Existing Hook Scripts #115

Open
5 tasks done
jaxinewolfe opened this issue Jul 9, 2024 · 2 comments
Open
5 tasks done

Corrections to Existing Hook Scripts #115

jaxinewolfe opened this issue Jul 9, 2024 · 2 comments
Assignees

Comments

@jaxinewolfe
Copy link
Collaborator

jaxinewolfe commented Jul 9, 2024

Running list:

  • Spot correction for Kauffman depths:
    mutate(
    depth_min = case_when(study_id == "Kauffman_et_al_2020_Brazil" & depth_max == 15 ~ 0,
    study_id == "Kauffman_et_al_2020_Brazil" & depth_max == 30 ~ 15,
    study_id == "Kauffman_et_al_2020_Brazil" & depth_max == 50 ~ 30,
    study_id == "Kauffman_et_al_2020_Brazil" & depth_max == 100 ~ 50,
    study_id == "Kauffman_et_al_2020_Brazil" & depth_max == 300 ~ 100,
    T ~ depth_min))

  • Make Kemp core IDs more unique
    study_id == "Kemp_et_al_2024" ~ paste(site_id, core_id, sep = "_")

  • "Tully_et_al_2024" surface samples should have unique core IDs

  • Schieder_and_Kirwan_2019 depthseries intervals overlapping in G12 and G13? At minimum, cores should be further distinguished by combining core_id and method_id

  • Add missing original paper citation for Phang et al 2016 (Sanderman synthesis): https://doi.org/10.1002/esp.3745

@cheneyr cheneyr self-assigned this Aug 19, 2024
cheneyr added a commit that referenced this issue Sep 6, 2024
@jaxinewolfe
Copy link
Collaborator Author

jaxinewolfe commented Sep 11, 2024

@cheneyr one more for you:

  • Kusumaningtyas_et_al_2018 has some carbon isotope values that didn't need to be converted - can you drop line 241 in the hook script?

I'll take care of the Kauffman_et_al_2020_Brazil

@cheneyr
Copy link
Collaborator

cheneyr commented Sep 11, 2024

@cheneyr one more for you:

  • Kusumaningtyas_et_al_2018 has some carbon isotope values that didn't need to be converted - can you drop line 241 in the hook script?

I'll take care of the Kauffman_et_al_2020_Brazil

Yes will do! Which Kauffman_et_al_2020_Brazil do we need to fix? I found the same study_id in some of the CIFOR data and the Maxwell synthesis?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants