Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSX nodes should not specify children as an attribute #2

Open
haykam821 opened this issue Feb 24, 2024 · 0 comments
Open

JSX nodes should not specify children as an attribute #2

haykam821 opened this issue Feb 24, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@haykam821
Copy link
Member

haykam821 commented Feb 24, 2024

Currently, children of JSX nodes are specified through the children attribute of a self-closing tag.

<h3
	className={q.a.secondaryHeaderText}
	children={["I agree to the following:"]}
/>

Properly placing children within the node between two tags would improve readability and be more in line with typical source code. For example:

<h3 className={q.a.secondaryHeaderText}>
	I agree to the following:
</h3>
@haykam821 haykam821 added the enhancement New feature or request label Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant