Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra] Refactor SonarLintSettings to follow VS threading rules #4843

Closed
duncanp-sonar opened this issue Sep 5, 2023 · 0 comments · Fixed by #4850
Closed

[Infra] Refactor SonarLintSettings to follow VS threading rules #4843

duncanp-sonar opened this issue Sep 5, 2023 · 0 comments · Fixed by #4850
Labels
Infrastructure Project structure, build and release pipeline etc Threading Relates to thread handling - be careful! Type: Task

Comments

@duncanp-sonar
Copy link
Contributor

Description

SonarLintSettings does not have a free-threaded MEF constructor (it creates a concrete VS base class - new ShellSettingsManager(serviceProvider)).

Notes

There is a VS Extensibility sample in GitHub, described as a best practice](https://github.com/microsoft/VSSDK-Extensibility-Samples/tree/master/Options). NB the sample also creates an Options page, which is not needed to SonarLintSettings.

See also the VSIX Community page on options and settings.

Related:
@duncanp-sonar duncanp-sonar added Type: Task Infrastructure Project structure, build and release pipeline etc Threading Relates to thread handling - be careful! labels Sep 5, 2023
@duncanp-sonar duncanp-sonar mentioned this issue Sep 5, 2023
Open
duncanp-sonar added a commit that referenced this issue Sep 5, 2023
@duncanp-sonar
Refactor SonarLintSettings to follow VS threading rule
60b0863 
Fixes #4843
@duncanp-sonar duncanp-sonar mentioned this issue Sep 5, 2023
Merged
@duncanp-sonar duncanp-sonar linked a pull request Sep 5, 2023 that will close this issue
Refactor SonarLintSettings to follow VS threading rules #4850
Merged
duncanp-sonar added a commit that referenced this issue Sep 6, 2023
@duncanp-sonar
Refactor SonarLintSettings to follow VS threading rules (#4850)
d3f14fe 
* Refactor SonarLintSettings to follow VS threading rule

Fixes #4843
duncanp-sonar added a commit that referenced this issue Sep 26, 2023
@duncanp-sonar
Refactor SonarLintSettings to follow VS threading rules (#4850)
473ec03 
* Refactor SonarLintSettings to follow VS threading rule

Fixes #4843
ugras-ergun-sonarsource pushed a commit that referenced this issue Oct 9, 2023
@duncanp-sonar @ugras-ergun-sonarsource
Refactor SonarLintSettings to follow VS threading rules (#4850)
1c22af5 
* Refactor SonarLintSettings to follow VS threading rule

Fixes #4843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Infrastructure Project structure, build and release pipeline etc Threading Relates to thread handling - be careful! Type: Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor SonarLintSettings to follow VS threading rules SonarSource/sonarlint-visualstudio
1 participant
@duncanp-sonar