Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide calculated branch to SLOOP #5401

Open
georgii-borovinskikh-sonarsource opened this issue May 3, 2024 · 0 comments
Open

Provide calculated branch to SLOOP #5401

georgii-borovinskikh-sonarsource opened this issue May 3, 2024 · 0 comments
Assignees
@georgii-borovinskikh-sonarsource
Labels
Type: Task

Comments

@georgii-borovinskikh-sonarsource
Copy link
Contributor

georgii-borovinskikh-sonarsource commented May 3, 2024 •
edited
Loading

Sloop has 2 methods: didChangeMatchedSonarProjectBranch that requests the client to calculate the branch and matchSonarProjectBranch that notifies the client about changing of the branch. Currently they always happen subsequently, but in the future the core will serve as the primary source of truth for the branch name, including possibly calculating the branch by itself. More here:https://sonarsource.atlassian.net/browse/SLCORE-570

Currently we're fine with just returning the master branch for the first method, but in the future it might be beneficial to integrate this properly.
georgii-borovinskikh-sonarsource added a commit that referenced this issue May 30, 2024
@georgii-borovinskikh-sonarsource
Add link to BranchListener doc strings with info about proper impleme…
52447b6 
…ntation

#5401
Merged
georgii-borovinskikh-sonarsource added a commit that referenced this issue May 31, 2024
@georgii-borovinskikh-sonarsource
Add link to BranchListener doc strings with info about proper impleme…
74b75a4 
…ntation (#5463)

#5401
georgii-borovinskikh-sonarsource added a commit that referenced this issue Jun 4, 2024
@georgii-borovinskikh-sonarsource
Add link to BranchListener doc strings with info about proper impleme…
0565a65 
…ntation (#5463)

#5401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgii-borovinskikh-sonarsource georgii-borovinskikh-sonarsource

Labels
Type: Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@georgii-borovinskikh-sonarsource