Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

videos without audio #122

Closed
1 task
SpEcHiDe opened this issue Sep 30, 2020 · 1 comment
Closed
1 task

videos without audio #122

SpEcHiDe opened this issue Sep 30, 2020 · 1 comment
Labels
bug Something isn't working enhancement New feature or request invalid This doesn't seem right question Further information is requested

Comments

@SpEcHiDe
Copy link
Owner

currently, only youtube videos are handled with this condition, https://github.com/SpEcHiDe/PublicLeech/blob/master/tobrot/helper_funcs/youtube_dl_button.py#L117, but we can't know which formats will have audios untill we explicitly download and tweak,

  • check if there is any generic method, to identify when yo use +bestaudio toggle, and when not to.
@SpEcHiDe SpEcHiDe added bug Something isn't working enhancement New feature or request invalid This doesn't seem right question Further information is requested labels Sep 30, 2020
@anon97945
Copy link

anon97945 commented Sep 30, 2020 •
edited
Loading

Don't know how to fetch the choosen format description.
Code could be somethong like this

  minus_f_format = youtube_dl_format
    if "video only" in youtube_dl_format_desc and not "youtu" in youtube_dl_url:
        minus_f_format = youtube_dl_format + "+bestaudio"

bhoomi-s-007 added a commit to bhoomi-s-007/PublicLeech that referenced this issue Mar 26, 2021
@bhoomi-s-007 @SpEcHiDe
@SayanthD @gautamajay52
Merge (#1)
bdfb0e9 
* closes SpEcHiDe#122 and SpEcHiDe#124

* this should probably fix SpEcHiDe#129 🤔😑

* testing fixes

* add SUDO users, to fix sensitive commands, Thank You: https://t.me/c/1459557988/45270, SpEcHiDe#129 should be fine, now.

* copy from @gautamajay52

* fix requirements

* fix one derp, in BUTTONs mode

* Fix issues with ytdl on command input mode (SpEcHiDe#140)

* fixed issue where format selector menu got removed upon selecting any video format
* fixed ValueError on audio format selections

* Fix leeching torrent from links (SpEcHiDe#148)

* simple fix (SpEcHiDe#150)

Co-authored-by: Shrimadhav U K <[email protected]>
Co-authored-by: Sayanth Dinesh <[email protected]>
Co-authored-by: Sayanth Dinesh <[email protected]>
Co-authored-by: GautamKumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request invalid This doesn't seem right question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SpEcHiDe @anon97945