Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust toolbar classes #1

Open
dshorthouse opened this issue Mar 25, 2020 · 3 comments
Open

Adjust toolbar classes #1

dshorthouse opened this issue Mar 25, 2020 · 3 comments

Comments

@dshorthouse
Copy link

Awesome, simple first pass at this. One suggestion is to adjust classes of buttons for :hover and :focus so it's evident to the user which button has been selected.

@mjy
Copy link
Member

mjy commented Mar 25, 2020

Ultimately this library won't include buttons, just the events/hooks to change type. Users will implement the type selection however tthey want.

@dshorthouse
Copy link
Author

Ultimately this library won't include buttons, just the events/hooks to change type. Users will implement the type selection however tthey want.

Fair enough but is there any harm in doing both as a first pass? Injecting buttons as part of the library will reduce some of the load off developer for config & set-up, no?

@jlpereira
Copy link
Member

jlpereira commented Mar 25, 2020

Toolbar and library are separate classes, both could be added to the package to be used together or just the core. For now its a experiment, but its a good point. I think we can add a default one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants