Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addMixinsTo tasks make bad assumptions that result in task dependency loops #55

Open
lukebemish opened this issue Aug 1, 2024 · 0 comments

Comments

@lukebemish
Copy link

Currently, a addMixinsTo... task is created for every single jar task, and is made to depend on the compileJava task for the source set being configured: https://github.com/SpongePowered/MixinGradle/blob/master/src/main/groovy/org/spongepowered/asm/gradle/plugins/MixinExtension.groovy#L1024-L1043

Unfortunately, this has some problematic side effects. Namely, it means that making compileJava depend on any Jar task from the same project will immediately result in an unfixable task dependency loop. I discovered this while investigating an incompatibility between MixinGradle and Registration Utils, but it will pop up any time that you have, say, a compileOnly dependency on a local Jar task or the like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant