Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API-8] Command error messages include exception information #3598

Open
ejm opened this issue Jan 16, 2022 · 2 comments
Open

[API-8] Command error messages include exception information #3598

ejm opened this issue Jan 16, 2022 · 2 comments
Labels
status: blocked there is another issue / pr that MUST be merged before this one system: command

Comments

@ejm
Copy link

ejm commented Jan 16, 2022

If it is better to merge this into SpongePowered/SpongeAPI#2385 somehow, let me know please!

Right now, when running a command with a parsing error, you receive an error message like this (example is a Parameter.user() encountering a user who has never logged into the server before):
image

While descriptive, from a player's perspective it offers a lot more information than necessary. In asking about this on Discord, I received the following response from @dualspiral and was asked to add an issue to the tracker about it:

Right now - no. I believe that's a vanilla thing that's going on there as we integrate with Brig quite tightly.

It might become possible later, I have plans to decouple us from Brig a bit for a few reasons, meaning that we take more control over the messages. That's quite a big chunk of work I need to do, and I need to be able to sit down without distraction to do it, and I may not get chance to do so until March.

For the above error message, I would expect something more straight forward like just Could not find user with user name "SlowRiot" without the exception information.

@dualspiral
Copy link
Contributor

If it is better to merge this into SpongePowered/SpongeAPI#2385 somehow, let me know please!

It's not the same issue, don't merge it.

@dualspiral dualspiral transferred this issue from SpongePowered/SpongeAPI Jan 17, 2022
@dualspiral dualspiral added status: blocked there is another issue / pr that MUST be merged before this one system: command labels Jan 17, 2022
@dualspiral
Copy link
Contributor

#3594 needs to come first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked there is another issue / pr that MUST be merged before this one system: command
Projects
None yet
Development

No branches or pull requests

2 participants