Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return type of Container#type() #2479

Open
MrHell228 opened this issue Nov 19, 2023 · 0 comments
Open

Return type of Container#type() #2479

MrHell228 opened this issue Nov 19, 2023 · 0 comments
Labels
status: needs triage This label is automatically applied to new issues and pull requests to indicate they require triage

Comments

@MrHell228
Copy link
Contributor

MrHell228 commented Nov 19, 2023 •
edited
Loading

Major SpongeAPI version

8

Is this likely to be a breaking change?

Yes

What are you requesting?

Change Container#type() return type from ContainerType to Optional< ContainerType> because it's nullable (e.g. in ClickContainerEvent#inventory() when interacting with just player's inventory)
@MrHell228 MrHell228 added the status: needs triage This label is automatically applied to new issues and pull requests to indicate they require triage label Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: needs triage This label is automatically applied to new issues and pull requests to indicate they require triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MrHell228