Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes on Signature of inner class #149

Open
martinezmatias opened this issue Mar 9, 2021 · 0 comments
Open

Changes on Signature of inner class #149

martinezmatias opened this issue Mar 9, 2021 · 0 comments

Comments

@martinezmatias
Copy link
Contributor

martinezmatias commented Mar 9, 2021

If we update the constructor call of a inner class, e.g: (from case examples/t_225073)

- new Lock.With(directory.makeLock("commit.lock")) {..
+ new Lock.With(directory.makeLock("commit.lock"), COMMIT_LOCK_TIMEOUT) { ...

when the diff produces two changes (all ops): update new class and insert literal., and one root op (the update).
I would say that the update of new class is redundant, but if we keep only the insert (by changing the label of the new class to print the name rather than the signature) we lose some information about the context of the change.

This issue was found when creating the fix for #147 created by @algomaster99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant