Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NopolResult should be created when calling build and not shared #124

Open
surli opened this issue Mar 1, 2017 · 3 comments
Open

NopolResult should be created when calling build and not shared #124

surli opened this issue Mar 1, 2017 · 3 comments

Comments

@surli
Copy link
Collaborator

surli commented Mar 1, 2017

No description provided.

@monperrus
Copy link
Contributor

@surli do you remember what you meant? could we close this one?

@surli
Copy link
Collaborator Author

surli commented Mar 16, 2018

In Nopol we should not use NopolResult as a field, it should be stateless regarding the result and create it only when calling build() method.

could we close this one?

No. It's not fixed yet.

@monperrus
Copy link
Contributor

We pass the NopolContext to the constructor. Since, there is a one-to-one mapping between NopolContext and NopolResult, I don't see a problem here.

You can create as many Nopol objects as you need (until recently there was a problem with a static field currentStatement but this has been removed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants