[BugFix] Support catalog name in Show materialized views #56174
+83
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghmargoor
changed the title
stevenzwu
reviewed
Feb 21, 2025
| @@ -310,7 +310,14 @@ public ShowResultSet visitShowStatement(ShowStmt statement, ConnectContext conte | |||
| @Override | |||
| public ShowResultSet visitShowMaterializedViewStatement(ShowMaterializedViewsStmt statement, ConnectContext context) { | |||
| String dbName = statement.getDb(); | |||
| Database db = GlobalStateMgr.getCurrentState().getLocalMetastore().getDb(dbName); | |||
| String catalogName = statement.getCatalogName(); | |||
There was a problem hiding this comment.
why do we need to update/fix ShowExecutor for show materialized views?
There was a problem hiding this comment.
because ShowExecutor handles the SHOW command including show materialised views.
There was a problem hiding this comment.
oh. Somehow I thought ShowExecutor is for show backends for the backend/executor nodes. This is for executing show statements.
amoghmargoor
force-pushed
the
mv_catalog_issue_oss
branch
from
7695997 to
038fa62
Compare
murphyatwork
previously approved these changes
Feb 26, 2025
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[FE Incremental Coverage Report]❌ fail : 12 / 16 (75.00%) file detail
|
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Signed-off-by: Amogh Margoor <[email protected]>
amoghmargoor
force-pushed
the
mv_catalog_issue_oss
branch
from
038fa62 to
ea1e8d7
Compare
|
@murphyatwork Just added UT for more code coverage. Can you reapprove it ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
Show Materialized View should honor fully qualified name of database ie.., catalog_name.database_name which fails currently
mysql> mysql> show materialized views from default_catalog.test; ERROR 5501 (3F000): Getting analyzing error. Detail message: Unknown database 'default_catalog.test'. mysql> mysql>What I'm doing:
In this patch the catalog name will be accepted as a part of fully qualified database name in
SHOW MATERIALIZED VIEW.Fixes #54134
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: