Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix code-style-guides' titles for protobuf and thrift. (backport #56324) #56381

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 27, 2025

Why I'm doing:

The table-of-content for code-style-guides is not really helpful in its current form:

image

What I'm doing:

Renamed the titles of the files to be more explicit (keeping the same naming as the .md files) :

  1. Rules -> Protobuf Guides
  2. Rules -> Thrift Guides

Fixes #56323

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@github-actions github-actions bot added documentation Improvements or additions to documentation automerge labels Feb 27, 2025
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) February 27, 2025 13:04
@wanpengfei-git wanpengfei-git merged commit b8d1119 into branch-3.3 Feb 27, 2025
32 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-56324 branch February 27, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge documentation Improvements or additions to documentation version:3.3.11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants