Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean comment/code for carriage returns #19

Open
cdelahousse opened this issue Feb 5, 2013 · 5 comments
Open

clean comment/code for carriage returns #19

cdelahousse opened this issue Feb 5, 2013 · 5 comments
Labels

Comments

@cdelahousse
Copy link
Member

Imported issue by Gankro from 2012-07-23T03:17:24Z
Originally opened as SteamedPears/CodeReviewClientMaster#73


When code or comments are submitted all carriage returns should be removed to ensure diff computation does not encounter errors.

@spratt
Copy link
Member

spratt commented Feb 5, 2013

Don't we want to track changes in carriage returns?

@psimonyi
Copy link
Contributor

psimonyi commented Feb 6, 2013

... what kind of code are you reviewing that this would matter for?

@spratt
Copy link
Member

spratt commented Feb 19, 2013

New lines are an important part of code formatting. I suspect that this bug actually means to standardize on newline characters to mark newlines, which is fair.

@bheesham
Copy link
Member

Yeah, I remember talking about this. Silly bug.

@psimonyi
Copy link
Contributor

Normalizing all line breaks seems like a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants