Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible workdir issue #11

Open
mikeh2 opened this issue Feb 14, 2020 · 0 comments
Open

Possible workdir issue #11

mikeh2 opened this issue Feb 14, 2020 · 0 comments

Comments

@mikeh2
Copy link

mikeh2 commented Feb 14, 2020

I come without a lot of docker experience. But in the file sandboxes.py, the run function has a named parameter workdir. This is passed down the chain all the way to _create_sandbox_container

When that function (_create_sandbox_container) creates a container, it uses config.DOCKER_WORKDIR and NOT the incoming parameter.

Perhaps in run, the default value for workdir should be set to config.DOCKER_WORKDIR instead and pass that value down the chain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant