Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Down arrow (keyboard) not work in the drop down for more then 10 elements in a list #82

Open
hardik-singhal opened this issue Nov 11, 2019 · 5 comments

Comments

@hardik-singhal
Copy link

No description provided.

@hardik-singhal
Copy link
Author

@StevenDevooght Please look into this

@StevenDevooght
Copy link
Owner

Hi,

Can you create a fiddle reproducing the problem?

@shivarchit
Copy link

@StevenDevooght , I had a similar issue, where I needed to view options via keyboard only, the options get hidden when the <ul> dropdown has a fixed height and a large number of options are available, the highlighted option does not remain, in the view. Here is fiddle example

https://jsfiddle.net/shivarchit/og2fq3b4
I fixed this by adding scrollIntoView(false) under your plugin.js when keyboard functions are triggered.

Also, I accidentally created the wrong pull request, sorry about that.
This is what I added,

var element = this.$dropdown.find('li').eq(index);
element[0].scrollIntoView({ block: 'nearest', inline: 'nearest', behavior: 'smooth' });

to highlightNextResult and highlightPreviousResult functions in plugin.js

@hardik-singhal
Copy link
Author

@shivarchit Thankyou for providing the fiddle, I also have the same issue with the tinyMCE-mention . I tried the solution you provided in your last comment and it works. thanks for helping but i will ask @StevenDevooght to update this in the project so that it can be directly used without changing every time we install tinyMCE-mentions.
Thanks!

@developeronboard
Copy link

@hardik-singhal can you favour me a help? can you check and tell whether this plugin works on mobile? If so what is the procedure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants