Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab user permissions must be owner or master to add the project into strider #23

Open
leutrimhusaj opened this issue Jun 11, 2015 · 2 comments

Comments

@leutrimhusaj
Copy link

When we configure a gitlab account to import the projects into strider, it was possible in v1.0.7 that the gitlab user, which token is configured in strider has only guest access in his gitlab account.
But in v1.1.0 the user now has to be owner or master of the group which projects are imported.
Now there is an error:
"results":[],
"status":"error",
"errors":[
{"code":500,"reason":"Failed to setup repo: undefined"}
]

Strider is receiving an 403 Forbidden from Gitlab when sending Api-Calls for creating the hooks and adding the Deployment Keys.

Is this correct that the user has to have this high access rights or isn't it possible with guest access too?

@knownasilya
Copy link
Member

Not sure about gitlab, but in Bitbucket you need admin rights to add repos. @oliversalzburg do you have any thoughts?

@oliversalzburg
Copy link
Member

This is probably identical to Strider-CD/strider#803

The user must have the permissions to install the hooks and keys, otherwise the import will fail.

As I mentioned in the other ticket, I'm not sure how strider should behave here. It could ignore those permission errors, then the user could at least import the project and trigger test/deploy manually, or there should be a workflow to allow the user to register hooks and keys manually (so that someone with higher privileges on Gitlab can perform the task).

Given that the latter path would include implementing the former, I would propose that the error handling in these situations is relaxed and improved. Failing to register the hooks should not prevent the user from importing and the problem (and solution) needs to be made perfectly clear in the frontend UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants