-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving to Kotlin 2 (once 2.0.20 is released) #153
Comments
Probably in 3/4 months? We can already try out K2 tho. |
Just compiled/tested with K2, all good! |
Great! |
I guess with Kotlin 2, the K2 compiler is enabled by default, right? |
Yes, exactly. K1 will be available for some minor versions IIRC (e.g., 2.2), so there is no rush in case of issues (which we don't have anyway). |
Will the generated code improve with K2? This comment seems to hint at it. |
@sschuberth in this specific case we might benefit of future language capabilities, but the main improvement is a bit of speed up when building. No changes for generated code, but in case you can be more specific and I can try to answer. |
I've tested Beta4 today with the K2 IDE. |
Now Kotlin 2.0.0 has been released, so we could check the situation and decide if we want to move to K2 using API 1.9 |
I've been observing the situation since beta versions. My advice is to wait until 2.0.20. That's what most issues, and they are a lot, are targeting. |
Noted, thank you |
Like, stuff like KT-68538 needs to be fixed before considering an update to 2.0+. |
2.0.20-Beta1 should be out mid next week. |
2.0.20 stable is here |
@JesusMcCloud I'm going to verify the project compiled on 2.0.20 will be consumable by 1.9.24 without issues on Monday, and then I'll open a PR. |
Note that I want to deliver one last potentially breaking change before releasing 1.0.0 on Kotlin 2.0.20. |
thanks! I just stumbled upon this issue here, because the dependency on an incompatible kotlin-reflect messes with one of our (rather complex) projects on kotlin 2.0.0 |
@JesusMcCloud I guess the dependency you're mentioning is this one:
I'm not sure why it was added, but given we don't depend on reflect features, I'll get rid of it. |
Should we move to a newer version of Gradle? here it says that:
perhaps as part of this task we should move to the gradle wrapper 8.8 |
Seems reasonable. I'll do that too, we should get slightly better build times too. |
Would it be possible to publish one last intermed. snapshot release before the final one (not talking about RC, but a real snapshot)? |
I am not sure we can publish snapshots or how to do that, but if you want I can do another RC |
My idea is the following.
|
Another RC is fine too. Getting rid of reflection is more important to us than K2 at the moment. Would be very much appreciated! |
I released RC5 right now. We can now proceed with the plan suggested by @lppedd and release 1.0.0 and then 1.1.0 however @JesusMcCloud can use RC5 right away. |
Hello, Can you please tell what is the state of migrating to Kotlin 2? I'd also be glad to help with migration |
KT-73130 is another one that could mess up the JS parser. |
Hey @lppedd it seems like both issues had been fixed now 🙌 |
All in all it looks like 2.1.20 will be the version to update to. |
I'd like to understand this first. |
Kotlin 2 is coming, bringing benefits to the multi-platform projects.
Current versions of Kotlin 2 (Kotlin 2.0.0-Beta3 as of now) cannot be used in production, but we may start running experiments to see if there are issues with the Kotlin 2 compiler. In my experience with other projects the migration was rather smooth, but this is a project supporting many platforms and perhaps there could be more suprises.
The text was updated successfully, but these errors were encountered: