From 0ce5d06dc9080c4ad4611db3fcf1cfee319c091b Mon Sep 17 00:00:00 2001 From: murajun1978 Date: Mon, 30 Dec 2024 21:29:25 +0900 Subject: [PATCH 1/2] Add ruby 3.4 support --- .github/workflows/test.yml | 5 ++++- grover.gemspec | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 3c30f04..458474e 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -17,7 +17,7 @@ jobs: strategy: fail-fast: false matrix: - ruby-version: ['3.3'] + ruby-version: ['3.4'] node-version: ['18'] puppeteer-version: [ '18.2.1', @@ -43,6 +43,9 @@ jobs: - ruby-version: '3.3' node-version: '22' puppeteer-version: '23.8.0' + - ruby-version: '3.4' + node-version: '22' + puppeteer-version: '23.8.0' steps: - uses: actions/checkout@v3 diff --git a/grover.gemspec b/grover.gemspec index f860d6c..6832c7f 100644 --- a/grover.gemspec +++ b/grover.gemspec @@ -16,7 +16,7 @@ Gem::Specification.new do |spec| SUMMARY spec.homepage = 'https://github.com/Studiosity/grover' spec.license = 'MIT' - spec.required_ruby_version = ['>= 3.0.0', '< 3.4.0'] + spec.required_ruby_version = ['>= 3.0.0', '< 3.5.0'] # Prevent pushing this gem to RubyGems.org by setting 'allowed_push_host', or # delete this section to allow pushing this gem to any host. From 39da29edcdfaacb6c1e946f687680bc4ec5b9581 Mon Sep 17 00:00:00 2001 From: Andrew Bromwich Date: Mon, 13 Jan 2025 21:35:36 +1000 Subject: [PATCH 2/2] Fix up build matrix node versions --- .github/workflows/test.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 458474e..5133efc 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -38,10 +38,10 @@ jobs: node-version: '18' puppeteer-version: '23.8.0' - ruby-version: '3.3' - node-version: '20' + node-version: '18' puppeteer-version: '23.8.0' - - ruby-version: '3.3' - node-version: '22' + - ruby-version: '3.4' + node-version: '20' puppeteer-version: '23.8.0' - ruby-version: '3.4' node-version: '22'