Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.4 support #275

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Add Ruby 3.4 support #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ce5d06
Add ruby 3.4 support
murajun1978 Dec 30, 2024
39da29e
Fix up build matrix node versions
abrom Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby-version: ['3.3']
ruby-version: ['3.4']
node-version: ['18']
puppeteer-version: [
'18.2.1',
Expand All @@ -38,9 +38,12 @@ jobs:
node-version: '18'
puppeteer-version: '23.8.0'
- ruby-version: '3.3'
node-version: '18'
puppeteer-version: '23.8.0'
- ruby-version: '3.4'
node-version: '20'
puppeteer-version: '23.8.0'
- ruby-version: '3.3'
- ruby-version: '3.4'
node-version: '22'
puppeteer-version: '23.8.0'

Expand Down
2 changes: 1 addition & 1 deletion grover.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Gem::Specification.new do |spec|
SUMMARY
spec.homepage = 'https://github.com/Studiosity/grover'
spec.license = 'MIT'
spec.required_ruby_version = ['>= 3.0.0', '< 3.4.0']
spec.required_ruby_version = ['>= 3.0.0', '< 3.5.0']
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abrom Any particular reason to lock Ruby version so tightly in this gem?

It'll be the same problem a few months later when 3.5 is released.
The gem prevents apps using it from upgrading Ruby.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it is not a reasonable restriction, except in the school of enterprisey business decisions. Please relegate it to the foibles of the Ruby ecosystem's past!
This is blocking upgrades for me, so I may switch to sourcing from a git fork.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abrom Any particular reason to lock Ruby version so tightly in this gem?

It'll be the same problem a few months later when 3.5 is released. The gem prevents apps using it from upgrading Ruby.

Because it hasn't been tested

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it is not a reasonable restriction, except in the school of enterprisey business decisions. Please relegate it to the foibles of the Ruby ecosystem's past! This is blocking upgrades for me, so I may switch to sourcing from a git fork.

Not reasonable to you, but expected by anyone who needs gems to work with the versions they're indicated as being supported by.

I agree that it is a blocker, no doubt about it. The Ruby versions releasing over what is traditionally a holiday for many, including myself, shouldn't dictate the entire community drop everything to support a pretty extreme minority who need instant version bumps 😉 . If you absolutely need to be using the latest Ruby as soon as it's released is going to result in the need, as you've suggested, for using forks.. that's a given.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abrom I get where you're coming from, but most gems don't seem to include a maximum supported Ruby version in their gemfiles from what I can tell, and for the most part this doesn't seem to lead to any problems. Is there a particular concern that grover is likely to break on new versions?

(Grover isn't the only one — I think I noticed nokogiri did too. But they released a new version the same day. I'm absolutely not going to suggest that you should be expected to release new versions on Christmas Day; but I do wonder if removing the upper bound would lead to any actual problems.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

😉


# Prevent pushing this gem to RubyGems.org by setting 'allowed_push_host', or
# delete this section to allow pushing this gem to any host.
Expand Down
Loading