Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code lenses look weird when syntax errors are reported #1123

Open
anderseknert opened this issue Sep 21, 2024 · 3 comments
Open

Code lenses look weird when syntax errors are reported #1123

anderseknert opened this issue Sep 21, 2024 · 3 comments
Labels
bug Something isn't working language server protocol

Comments

@anderseknert
Copy link
Member

We can't evaluate or debug files with syntax errors, but it looks like we keep sending these from the server in that case, presumably from the last known good state, which sometimes makes them appear in weird locations. We should simply not return anything in this case.

Screenshot 2024-09-21 at 20 37 54

Perhaps later on we can have those actions located before any syntax errors in the file remain and when clicked help the user understand more about the error... but it's likely better to show syntax errors in-lined like linter issues anyway. So let's just hide the actions for now.

@anderseknert anderseknert added bug Something isn't working language server protocol labels Sep 21, 2024
@charlieegan3
Copy link
Member

This is partly blocked by #1344, as we get 0 parse diags set now, so we can't tell if the module is stale or not.

@charlieegan3
Copy link
Member

I think the title is referring to Code Lenses rather than actions?

@anderseknert anderseknert changed the title Disable code actions on syntax errors Code lenses look weird when syntax errors are reported Jan 16, 2025
@anderseknert
Copy link
Member Author

Indeed! Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working language server protocol
Projects
None yet
Development

No branches or pull requests

2 participants