-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip templating when creating policy file in workspace root. Allow disabling templating. #1141
Labels
Comments
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this issue
Oct 3, 2024
This also disables templating for files in the root. Fixes StyraInc#1164 Related to StyraInc#1141, but this needs more work Signed-off-by: Charlie Egan <[email protected]>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this issue
Oct 7, 2024
This also disables templating for files in the root. Fixes StyraInc#1164 Related to StyraInc#1141, but this needs more work Signed-off-by: Charlie Egan <[email protected]>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this issue
Oct 7, 2024
This also disables templating for files in the root. Fixes StyraInc#1164 Related to StyraInc#1141, but this needs more work Signed-off-by: Charlie Egan <[email protected]>
charlieegan3
added a commit
that referenced
this issue
Oct 7, 2024
* lsp/templating: gracefully unknown root This also disables templating for files in the root. Fixes #1164 Related to #1141, but this needs more work Signed-off-by: Charlie Egan <[email protected]> * Guard rather than use error control flow Signed-off-by: Charlie Egan <[email protected]> * Correct test error message Signed-off-by: Charlie Egan <[email protected]> --------- Signed-off-by: Charlie Egan <[email protected]>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this issue
Jan 6, 2025
* lsp/templating: gracefully unknown root This also disables templating for files in the root. Fixes StyraInc#1164 Related to StyraInc#1141, but this needs more work Signed-off-by: Charlie Egan <[email protected]> * Guard rather than use error control flow Signed-off-by: Charlie Egan <[email protected]> * Correct test error message Signed-off-by: Charlie Egan <[email protected]> --------- Signed-off-by: Charlie Egan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We currently create a "main" directory for this and move it there. This has rightly been perceived as confusing, and there's nothing in this process that provides a clue as to why this happened. We could add a comment or something like that in the template, but a simpler approach is to just skip templating in the workspace root. This will instead flag a violation, giving users a chance to learn about it, and disable it if they so want.
On the topic of disabling, we should also allow disabling templating altogether.
The text was updated successfully, but these errors were encountered: