Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have regal lint fail when unknown category or rule is provided via --enable/--disable options #1214

Closed
anderseknert opened this issue Oct 21, 2024 · 0 comments · Fixed by #1381
Closed

Have regal lint fail when unknown category or rule is provided via --enable/--disable options #1214

anderseknert opened this issue Oct 21, 2024 · 0 comments · Fixed by #1381
Labels
tooling

Comments

@anderseknert
Copy link
Member 

regal lint --disable-all --enable foo .

Should have regal fail loudly unless the foo rule was actually found. Currently it'll just report this as a success, which while technically true, is not likely to be what the user wanted. Note that we'll also need to take custom rules into account, so this is probably a check we'll have to do some time into initialization.
charlieegan3 added a commit to charlieegan3/regal that referenced this issue Jan 30, 2025
@charlieegan3
linter: Show error if rule or category is invalid
1f67421 
Fixes StyraInc#1214

Signed-off-by: Charlie Egan <[email protected]>
charlieegan3 added a commit to charlieegan3/regal that referenced this issue Jan 30, 2025
@charlieegan3
linter: Show error if rule or category is invalid
75c599b 
Fixes StyraInc#1214

Signed-off-by: Charlie Egan <[email protected]>
@charlieegan3 charlieegan3 mentioned this issue Jan 30, 2025
Merged
charlieegan3 added a commit to charlieegan3/regal that referenced this issue Jan 30, 2025
@charlieegan3
linter: Show error if rule or category is invalid
ede8c92 
Fixes StyraInc#1214

Signed-off-by: Charlie Egan <[email protected]>
charlieegan3 added a commit to charlieegan3/regal that referenced this issue Jan 30, 2025
@charlieegan3
linter: Show error if rule or category is invalid
b9e3ad0 
Fixes StyraInc#1214
charlieegan3 added a commit to charlieegan3/regal that referenced this issue Jan 30, 2025
@charlieegan3
linter: Show error if rule or category is invalid
4b39d3a 
Fixes StyraInc#1214

Signed-off-by: Charlie Egan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

linter: Show error if rule or category is invalid charlieegan3/regal
1 participant
@anderseknert