Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question: separating flow-bin initialization from subsequent calls to flow #66

Open
nsfmc opened this issue May 11, 2018 · 4 comments
Open

Comments

@nsfmc
Copy link
Contributor

nsfmc commented May 11, 2018

starting the flow server can take a minute or two (depending on the size of the codebase). nuclide and vscode sort of address this by hooking into flow's LSP server to run lint checks, but sublime linter just fires up the process and waits for a response (for however many views could be linted).

is there a way to have sublimelinter spawn the flow process separately from its subsequent calls to lint individual views (i looked at SublimeLinter/SublimeLinter#1250 and it seems like there was movement in this direction, but it seems like it was addressed differently as SublimeLinter/SublimeLinter#1234) I think the latter's approach is pretty sensible, but the initial flow startup time is a fairly deceptive metric.

it could also be that this isn't an issue in practice, that it eventually washes out, but i noticed sublimelinter crashing the plugin host in sublime text with this plugin and suspcted this might be the reason (there is no other logged information which might suggest the problem)

feel free to close, just wanted to ask if maybe there was some infra in place to do this efficiently.

@kaste
Copy link
Contributor

kaste commented May 14, 2018

There is always a way. We probably need to run flow start once per flow-bin. However, we never call stop 🤔 ?

@braver
Copy link
Member

braver commented May 17, 2018

but sublime linter just fires up the process and waits for a response (for however many views could be linted)

That's what SublimeLinter does. I don't know anything about Flow, but if it uses a language server behind the scenes, you really need a client to interact with it properly and SL isn't that. LSP is what you want here.

However, we never call stop 🤔 ?

Exactly, SL cannot interact with a language server correctly. It's very much out of scope, also because there is already a very nice LSP client in the ST eco-system.

So, I'm going to close, but if I'm not right here, let me know.

@braver braver closed this as completed May 17, 2018
@kaste kaste reopened this May 17, 2018
@kaste
Copy link
Contributor

kaste commented May 17, 2018

Yes you're wrong.

@braver
Copy link
Member

braver commented May 17, 2018

Ok ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants