Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set shell for embedded script #16

Open
braver opened this issue Jun 7, 2018 · 2 comments
Open

set shell for embedded script #16

braver opened this issue Jun 7, 2018 · 2 comments

Comments

@braver
Copy link
Member

braver commented Jun 7, 2018

via SublimeLinter/SublimeLinter#1446

Ok, so the primary thing that stops shellcheck from running on embedded code is that it can't determine what shell the script is for. So, the solution is to have a setting for shellcheck that sets the shell via an arg when the root scope isn't source.sh.

@nicodeceulaer
Copy link

As described here: https://github.com/koalaman/shellcheck/wiki/SC2148 this would be fixed by allowing sublimelinter-shellcheck to provide a default shell (using the -s command line option)?

@braver
Copy link
Member Author

braver commented Jun 14, 2018

-s doesn't provide a "default" but sets the value it will use regardless of the shebang. So you use one or the other. If I understand this correctly, it will use a reasonable default by itself, so we could also suppress the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants