From 46f38a0942b1163ca9ca2c2716aae0c8926895a5 Mon Sep 17 00:00:00 2001 From: Calvin Buckley Date: Sun, 31 Dec 2023 14:16:24 -0400 Subject: [PATCH] Fix crash accepting filenames from dock drop We take URLs, not Strings. Fix the header to be explicit, and don't map. Fixes the crash in GH-184. --- Submariner/SBAppDelegate.swift | 2 +- Submariner/SBDatabaseController.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Submariner/SBAppDelegate.swift b/Submariner/SBAppDelegate.swift index 3cb8ee0..3144ae5 100644 --- a/Submariner/SBAppDelegate.swift +++ b/Submariner/SBAppDelegate.swift @@ -151,7 +151,7 @@ fileprivate let logger = Logger(subsystem: Bundle.main.bundleIdentifier!, catego } func application(_ application: NSApplication, open urls: [URL]) { - databaseController.openImportAlert(databaseController.window, files: urls.map { $0.path }) + databaseController.openImportAlert(databaseController.window, files: urls) } // #MARK: - Application Files/Directories diff --git a/Submariner/SBDatabaseController.h b/Submariner/SBDatabaseController.h index 0b1424a..103b812 100644 --- a/Submariner/SBDatabaseController.h +++ b/Submariner/SBDatabaseController.h @@ -137,7 +137,7 @@ @property (readonly, strong) IBOutlet NSNumber *isServerUsersShown; @property (readonly, strong) IBOutlet NSNumber *isInspectorShown; -- (BOOL)openImportAlert:(NSWindow *)sender files:(NSArray *)files; +- (BOOL)openImportAlert:(NSWindow *)sender files:(NSArray *)files; - (void)goToTrack: (SBTrack*)track;