Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UI for stars #199

Open
NattyNarwhal opened this issue Feb 26, 2024 · 2 comments
Open

Improve UI for stars #199

NattyNarwhal opened this issue Feb 26, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@NattyNarwhal
Copy link
Member

  • Hover state: Hellish to implement with NSCell table views.
  • Menus: Context menus in views will be easy, main menu harder.
@NattyNarwhal NattyNarwhal added the enhancement New feature or request label Feb 26, 2024
@NattyNarwhal NattyNarwhal mentioned this issue Jun 15, 2024
Closed
NattyNarwhal added a commit that referenced this issue Jun 19, 2024
@NattyNarwhal
Favourite option in menu, and refactors to make it work
29c6de4 
- Make the starredBool implementors implement a protocol.
- Make SBViewController inheritors implement selectedTracks and a
  selectedMusicItems property (that is actually SBStarred).
- Make child classes make use of these.
- Make SBInspectorViewController not inherit from SBViewController
  because it doesn't make sense with the new focus of the former parent.
- Add some properties to SBDatabaseController that just surface the
  first responder SBViewController's selected items; adds some
  additional computed properties because binding directly to NSArray is
  pretty gross.
- Make SBDatabaseController observe track selection and indicate updates
  to the related properties.
- Add a menu option (Cmd+E) that sets up a binding on that property.

There are some interesting refactors possible, such as moving large
chunks of functionality implemented in children (including their
IBActions) into the parent SBViewController.

Current nitpick is the first responder changing in children (i.e. artist
or track table) should update the menu item's state.

Part of GH-199.
@NattyNarwhal
Copy link
Member Author

I think a context menu item is probably redundant with the main menu option and having it in tables.

@NattyNarwhal
Copy link
Member Author

Directories can be starred as well

NattyNarwhal added a commit that referenced this issue Oct 25, 2024
@NattyNarwhal
Make directories starrable, enhance directory view
c5ed18c 
Make the root dir consistent with children, fix drag items.

The SBViewController needs to be made aware of directories so it
automatically gets some improvements.

Addresses part of GH-199
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NattyNarwhal