Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null safety migration #161

Open
tungtrinh opened this issue Mar 9, 2021 · 14 comments · May be fixed by #178
Open

null safety migration #161

tungtrinh opened this issue Mar 9, 2021 · 14 comments · May be fixed by #178

Comments

@tungtrinh
Copy link

tungtrinh commented Mar 9, 2021

Since flutter stable is already 2.0 which requires null safety, please help to migrate the plugin.

@dgaedcke
Copy link

Is anyone working on this?? I'd be willing to help!!

@absar
Copy link
Contributor

absar commented May 23, 2021

This guy has done it, however he has removed many charts and examples, which is diverting from the actual repo
https://github.com/greensopinion/MPFlutterChart

@omidraha
Copy link

omidraha commented Jun 4, 2021

Which one of forks is null safety and it is more consistent?

https://github.com/SunPointed/MPFlutterChart/network

There is no PieChartController, PieChartRenderer, PieDataSet, PieData, PieChart, ... in many of them

@absar
Copy link
Contributor

absar commented Sep 1, 2021

hi @dgaedcke I think you started null safety, did you manage to complete it or opted for something else?

@ParvinderjitSF
Copy link

ParvinderjitSF commented Sep 24, 2021

Any update on this

@dgaedcke
Copy link

I did not finish my Null Safety conversion ... I was pulled onto another project but I plan to start looking at it again unless one of you has found a better solution ..

@Chakib-Temal
Copy link

I did not finish my Null Safety conversion ... I was pulled onto another project but I plan to start looking at it again unless one of you has found a better solution ..

Hi

I use your deposit, https://github.com/dgaedcke/MPFlutterChart
when I use the stable Flutter Sdk 2.2.3 version, I have no problem

but when I upgraded to the new version flutter 2.5.2

Git error. Command: git clone --mirror [email protected]:greensopinion/OptimizedGestureDetector.git /Users/macbookpro/Flutter_Sdk/2.5.2/flutter/.pub-cache/git/cache/OptimizedGestureDetector-2cf40e1ea4df4731549ecaacffc0d6fa4740e388
stdout:
stderr: Cloning into bare repository '/Users/macbookpro/Flutter_Sdk/2.5.2/flutter/.pub-cache/git/cache/OptimizedGestureDetector-2cf40e1ea4df4731549ecaacffc0d6fa4740e388'...
ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
exit code: 128

can u upgrade the repository with the new version Flutter sdk please ?
thank you

@m2faridi
Copy link

@Chakib-Temal
Copy link

full version https://github.com/Juniorlpes/MPFlutterChart

you mean a full version null safety ?

@m2faridi
Copy link

yes

@Chakib-Temal
Copy link

Chakib-Temal commented Jan 22, 2022

yes

did you fixed this errors ?
erros to fix

@m2faridi
Copy link

What problem does the error cause?

@Chakib-Temal
Copy link

What problem does the error cause?

take a look to my code (the value of high var can be null)
i fix this because i had a nullPointerException on Multiple LineChart Or CombinedChart when i select (by click) a value from a chart

Highlight? high = widget.controller.painter!.getHighlightByTouchPoint(
        details.localPosition.dx,
        details.localPosition.dy,
      );
if (high != null) widget.controller.painter!.selectedValue(high);

the second one is a problem with a Zoom

@absar absar linked a pull request Feb 22, 2022 that will close this issue
@balthier82
Copy link

When will absar's pull request be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants