Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring proposal #607

Closed
aviggiano opened this issue Apr 3, 2024 · 3 comments · Fixed by #622
Closed

Refactoring proposal #607

aviggiano opened this issue Apr 3, 2024 · 3 comments · Fixed by #622

Comments

@aviggiano
Copy link
Contributor

Hello,

I am starting to learn this codebase and I believe it could benefit from a structural refactor.

Currently, the README contains descriptions from various exploits, in chronological order, together with foundry reproducers. The issue is that the reproducers are all on the src folder, without any ordering whatsoever.

I propose a slight change on that structure:

images
  |_ ...
academy
  |_ ...
hacks
  |_ 2024
    |_ 01
      |_ OrbitChain_exp.sol

If you agree on this refactor, I can submit a PR
@SunWeb3Sec
Copy link
Owner

Hey, it makes sense to me. However, we can wait one day in case anyone has objections.
Thanks a lot!

@aviggiano
Copy link
Contributor Author

I guess I'll wait for the approval of #547, otherwise I'll make their lives harder

@SunWeb3Sec
Copy link
Owner

@aviggiano I have closed #547 , you can go ahead. thanks a lot.

@aviggiano aviggiano mentioned this issue Apr 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor repository structure aviggiano/DeFiHackLabs
2 participants
@aviggiano @SunWeb3Sec