Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing subtitle/audio doesn't trigger changedSubtitles or changedTrack event #12

Open
nateshmbhat opened this issue Aug 27, 2024 · 0 comments

Comments

@nateshmbhat
Copy link

nateshmbhat commented Aug 27, 2024

sample track to test : http://sample.vodobox.com/planete_interdite/planete_interdite_alternate.m3u8

test code :

vidController.addEventsListener((event) {
        final eventType = event.betterPlayerEventType;

        switch (eventType) {
          case BetterPlayerEventType.initialized:
            videoLog.i('BetterPlayerEventType.initialized');
            break;
          case BetterPlayerEventType.changedTrack:
            videoLog
                .i('BetterPlayerEventType.changedTrack : ${event.parameters}');
            break;
          case BetterPlayerEventType.changedSubtitles:
            videoLog.i(
                'BetterPlayerEventType.changedSubtitles : ${event.parameters}');
            break;
          case BetterPlayerEventType.bufferingUpdate:
          case BetterPlayerEventType.bufferingStart:
          case BetterPlayerEventType.bufferingEnd:
          case BetterPlayerEventType.progress:
            break;
          default:
            videoLog.i('BetterPlayerEventType.event: ${eventType}');
            break;
        }
      });
final controller = BetterPlayerController(
        BetterPlayerConfiguration(
          autoDispose: true,
          autoPlay: true,
          looping: true,
          aspectRatio: screenAspectRatio,
          subtitlesConfiguration: const BetterPlayerSubtitlesConfiguration(
              fontSize: 24,
              fontFamily: sFontFedraSerif,
              fontColor: Colors.blue,
              outlineEnabled: true,
              backgroundColor: Colors.white),
          controlsConfiguration: const BetterPlayerControlsConfiguration(
            enableFullscreen: false,
            enableSubtitles: true,
            showControls: true,
            showControlsOnInitialize: false,
          ),
          fit: BoxFit.contain,
        ),
        betterPlayerDataSource: BetterPlayerDataSource(
          BetterPlayerDataSourceType.network,
          videoDataModel.videoUrl,
          useAsmsAudioTracks: true,
          useAsmsSubtitles: true,
          useAsmsTracks: true,
          videoFormat: 'hls',
      );
      return controller;
    }, const []);

    useEffect(() {
      vidController.addEventsListener((event) {
        final eventType = event.betterPlayerEventType;

        switch (eventType) {
          case BetterPlayerEventType.initialized:
            videoLog.i('BetterPlayerEventType.initialized');
            break;
          case BetterPlayerEventType.changedTrack:
            videoLog
                .i('BetterPlayerEventType.changedTrack : ${event.parameters}');
            break;
          case BetterPlayerEventType.changedSubtitles:
            videoLog.i(
                'BetterPlayerEventType.changedSubtitles : ${event.parameters}');
            break;
          case BetterPlayerEventType.bufferingUpdate:
          case BetterPlayerEventType.bufferingStart:
          case BetterPlayerEventType.bufferingEnd:
          case BetterPlayerEventType.progress:
            break;
          default:
            videoLog.i('BetterPlayerEventType.event: ${eventType}');
            break;
        }
      });
      return () {
        vidController.removeEventsListener((e) {});
      };
    }, [vidController]);

expected behavior is :
changing subtitles from the default controls overflow menu should trigger changedSubtitles event.

Current behavior is :
event not triggered. Same issue for audio track change also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant