New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful handling of being unable to bind #26

Open

mzedeler opened this issue Mar 2, 2015 · 0 comments

mzedeler commented Mar 2, 2015

Binding to the samba related ports (137-139 and 445) in https://github.com/SvenDowideit/dockerfiles/blob/master/samba/setup.sh#L116-L119 doesn't necessarily work because there may be something else listening on those ports.

I suggest two fixes:

Making sure to report it as an error if they are already taken.
Making it possible to specify some other interface that the container should listen on.

I can provide a patch to fix both, if you want it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment