Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id postfix in open #241

Open
Ana06 opened this issue Jul 13, 2018 · 0 comments
Open

id postfix in open #241

Ana06 opened this issue Jul 13, 2018 · 0 comments

Comments

@Ana06
Copy link

Ana06 commented Jul 13, 2018

From Reference.md:

  service.open({

      id : "local.net/s+T6Ad2s2TC2A"

  }).then( object => {

  })
  .catch( error => { ... });

Object will be created with an autogenerated id, if no id argument is provided. Optionally, a "prefix" can be passed to use in the autogenerated id.

Isn't it a postfix and not a prefix? 😕 I find the name of the variable id confusing... what about id_postfix? It would make much more clear what this is doing. At the moment without readong the documentation I would think that it is the actual id and not a postfix 🤔 Can we change this kind of things? I mean I think that if only JetPad is using this, then it is fine to change this kind of things 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant